Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduced NLog.Wcf and Nlog.WindowsIdentity for .NET standard #2402

Merged
merged 1 commit into from
Nov 19, 2017
Merged

Introduced NLog.Wcf and Nlog.WindowsIdentity for .NET standard #2402

merged 1 commit into from
Nov 19, 2017

Conversation

snakefoot
Copy link
Contributor

NLog without extra dependencies for NetStandard2.0. Resolves #2400

@304NotModified
Copy link
Member

guess this should wait on the next major version ('cause of semver)

@snakefoot
Copy link
Contributor Author

Not sure I understand. There is no semver for NetStandard.

@304NotModified
Copy link
Member

the same comment as -> #2400

Semver for NLog.

@snakefoot
Copy link
Contributor Author

snakefoot commented Nov 18, 2017 •
edited
Loading

Hard to have breaking changes when never made an official release yet. And fixing the dependencies afterwards will cause more grief.

@304NotModified
Copy link
Member

sure only on officials releases. But it breaks stuff compared to 4.4.x isn't?

@snakefoot
Copy link
Contributor Author

snakefoot commented Nov 18, 2017 •
edited
Loading

There is no breaking change. The WCF stuffs is part of the Nlog.dll for NetFramework as always. It is just NetStandard2.0 that now has an extra dependency.

@304NotModified
Copy link
Member

oops sorry, missed that this was .net standard only

@304NotModified 304NotModified added this to the 4.5 beta 8 milestone Nov 18, 2017
@304NotModified 304NotModified changed the title Introduced NLog.Wcf and Nlog.WindowsIdentify Introduced NLog.Wcf and Nlog.WindowsIdentify for .NET standard Nov 18, 2017
@304NotModified 304NotModified added enhancement Improvement on existing feature feature labels Nov 18, 2017
@304NotModified
Copy link
Member

@snakefoot release of beta8 after this one?

@snakefoot
Copy link
Contributor Author

release of beta8 after this one?

Yes think that is a good idea. No more changes in the pipeline for me.

@snakefoot snakefoot force-pushed the NLogWcfNetStandard branch 2 times, most recently from 8d1d289 to b47f244 Compare November 18, 2017 22:28
@snakefoot snakefoot changed the title Introduced NLog.Wcf and Nlog.WindowsIdentify for .NET standard Introduced NLog.Wcf and Nlog.WindowsIdentity for .NET standard Nov 18, 2017
@304NotModified
Copy link
Member

👍

@snakefoot snakefoot force-pushed the NLogWcfNetStandard branch 2 times, most recently from bd00707 to 0b66d35 Compare November 18, 2017 23:16
@codecov
Copy link

codecov bot commented Nov 18, 2017 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@55c5849). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master   #2402   +/-   ##
========================================
  Coverage          ?     82%           
========================================
  Files             ?     320           
  Lines             ?   23012           
  Branches          ?    2844           
========================================
  Hits              ?   18789           
  Misses            ?    3491           
  Partials          ?     732

@snakefoot snakefoot force-pushed the NLogWcfNetStandard branch 2 times, most recently from 134b1ba to 58fb0bd Compare November 19, 2017 02:09
@snakefoot
Copy link
Contributor Author

Updated documentation:

https://github.com/NLog/NLog/wiki/Platform-Support

@304NotModified
Copy link
Member

thx!

@304NotModified 304NotModified merged commit b60bdf1 into NLog:master Nov 19, 2017
@304NotModified
Copy link
Member

304NotModified commented Nov 20, 2017 •
edited
Loading

FYI beta8 is live, including

https://www.nuget.org/packages/NLog.WindowsIdentity and https://www.nuget.org/packages/NLog.wcf

:)

@snakefoot
Copy link
Contributor Author

@304NotModified Looks great! Happy about the empty dependency-list for NetStandard2.0. Expects that NLog 5.0 (or maybe it should be 6.0) will focus on extracting even more targets/layout-renderers into separate nuget-packages.

Is something needed from this list to create a release-candidate: https://github.com/NLog/NLog/milestone/27 ?

@304NotModified
Copy link
Member

Is something needed from this list to create a release-candidate: https://github.com/NLog/NLog/milestone/27 ?

yes, #2355 and #2321

@snakefoot snakefoot mentioned this pull request Nov 23, 2017
Closed
@snakefoot snakefoot deleted the NLogWcfNetStandard branch December 4, 2017 19:48
@snakefoot snakefoot modified the milestones: 4.5 beta 8, 4.5 Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Improvement on existing feature feature
Projects
None yet
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@snakefoot @304NotModified