Date Based File Archiving

[mkaltner]

I made a few minor changes that allows archiving based on dates instead of rolling/sequential numbering.
The changes have minimal impact and work with the existing code/parameters as much as possible.
I found many posts/bug reports about deleting archive files with dates in the file name as I was having the same issue.
I've been testing this for a couple days and is working as expected.

Sample output showing archive files with datetime and maxArchiveFiles of 2 (The log file for 4:29 has been deleted):

Config used to achieve the results in the previous screenshot (archiveDateFormat is optional and will be generated based on archiveEvery setting if not specified):

[ghost]

Thanks for the pull request I'll take a look at it

[realityexists]

Date-based archiving would be a useful feature for me. Thanks, mkaltner. I hope this gets merged soon.

[Doomjunky]

I think you missused the archiveNumbering attribute. This attribute describes the schema how to number the archived files (Sequence|Rolling). This numbering strategies can be applied on dates too, but "dateNumbering" is not a numbering schema.

What you want is a trigger to archive a file. Here is my idea: a archiveTrigger attribute. Which takes values of Size|Date|Run. This attribute describes the trigger that creates a new file and archives the old file.

[ghost]

Thanks for the feedback, it sounds reasonable to do what you say, and I'll
will look into this.
But it would be a breaking change, so it won't be at least until version 4,
as 3 is in the final stage.

[mkaltner]

While I do agree with Doomjunky, Xharze's comment is the reason why I chose to implement the change the way I did. Sometimes it's better to minimally alter existing functionality versus making major changes to the project. That's not to say it couldn't be implemented better, architecturally speaking.

[alexeevk]

Thank you Mike!

[swapneeld]

👍