Logger - Added missing MessageTemplateFormatMethodAttribute + removed obsolete internal method #2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snakefoot
force-pushed
the
LoggerMessageTemplateAttrib
branch
from
ca342c6
to
654dfa8
Compare
Codecov Report
@@ Coverage Diff @@
## master #2419 +/- ##
=======================================
- Coverage 82% 82% -<1%
=======================================
Files 322 322
Lines 23020 23017 -3
Branches 2846 2846
=======================================
- Hits 18791 18780 -11
- Misses 3494 3504 +10
+ Partials 735 733 -2 |
| @@ -189,7 +189,7 @@ namespace NLog | |||
| { | |||
| if (Is<#=level#>Enabled) | |||
| { | |||
| WriteToTargets(LogLevel.<#=level#>, message, exception); | |||
| WriteToTargets(LogLevel.<#=level#>, exception, message, null); | |||
There was a problem hiding this comment.
why is this change needed?
There was a problem hiding this comment.
Because it referenced an obsolete internal method, that I have also removed (Leftovers from the reordering of the Exception-parameter to the front).
304NotModified
changed the title
|
ok thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #2345 and #2406