.NET Core - Improve auto loading of NLog extension dlls

[snakefoot]

NetCore-Console-Applications will usual be compiled to a dll, that is run by the dotnet-tool.

The NLog-package-reference will be loaded from an isolated path, and using this path to load NLog-extension-dlls will result in empty result.

Added extra fallback locations when the NLog-assembly-path returns empty file-list:

• Assembly.GetEntryAssembly() - Works for NetCore-Console-Application, but will be null for other cases (High probability this will be the private assembly path)
• AppDomain.BaseDirectory - Should also work for AspNetCore.

But it will not help with dlls coming from Nuget-packages. So maybe it is better to implement something using DependencyContext api to resolve the DLLs and their locations that are part of the application's dependency graph.

[codecov]

Codecov Report

Merging #2431 into master will decrease coverage by <1%.
The diff coverage is 37%.

@@           Coverage Diff           @@
##           master   #2431    +/-   ##
=======================================
- Coverage      82%     81%   -<1%     
=======================================
  Files         322     322            
  Lines       23046   23111    +65     
  Branches     2852    2862    +10     
=======================================
+ Hits        18817   18831    +14     
- Misses       3494    3544    +50     
- Partials      735     736     +1

[304NotModified]

But it will not help with dlls coming from Nuget-packages.

So it work only for projects in your solution isn't?

[snakefoot]

Yes it will only help in very few cases, and will change behaviour for existing users. Not entirely convinced myself this is a perfect PR :)

…

Sent from my Samsung device

-------- Original message -------- From: Julian Verdurmen <notifications@github.com> Date: 29/11/2017 22:06 (GMT+01:00) To: NLog/NLog <NLog@noreply.github.com> Cc: Rolf Kristensen <sweaty1@hotmail.com>, Author <author@noreply.github.com> Subject: Re: [NLog/NLog] NetCoreApp - Improve auto loading of NLog extension dlls (#2431) But it will not help with dlls coming from Nuget-packages. So it work only for projects in your solution isn't? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#2431 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AK-fnC1zfdXUrigCN11htUnBVs_LlYaaks5s7cc5gaJpZM4Qt8kp>.

[304NotModified]

small step forward is step forward :)

I think it's nice, maybe a bit more difficult to explain when it works and when don't