Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TreatWarningsAsErrors = true #2471

Merged
merged 1 commit into from
Jan 3, 2018

Conversation

snakefoot
Copy link
Contributor

And fix license url, so the link from Nuget-package becomes human readable.

@snakefoot snakefoot force-pushed the TreatWarningsAsErrors branch 2 times, most recently from 4683fea to 95b1812 Compare December 21, 2017 20:37
@codecov
Copy link

codecov bot commented Dec 21, 2017

Codecov Report

Merging #2471 into master will decrease coverage by <1%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #2471    +/-   ##
=======================================
- Coverage      81%     81%   -<1%     
=======================================
  Files         322     322            
  Lines       23170   23170            
  Branches     2877    2877            
=======================================
- Hits        18883   18882     -1     
- Misses       3538    3539     +1     
  Partials      749     749

@304NotModified 304NotModified added this to the 4.5 rc4 milestone Jan 3, 2018
@304NotModified 304NotModified added the enhancement Improvement on existing feature label Jan 3, 2018
@304NotModified
Copy link
Member

thanks! great enhancement!

@304NotModified 304NotModified merged commit a96acab into NLog:master Jan 3, 2018
@snakefoot snakefoot deleted the TreatWarningsAsErrors branch January 29, 2018 17:29
@snakefoot snakefoot modified the milestones: 4.5 rc4, 4.5 Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement on existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants