Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileTarget - Dispose Archive-Mutex after completing file-archive #2485

Merged

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Jan 2, 2018

Explicit cleanup, instead of waiting for the garbage collector.

@snakefoot snakefoot force-pushed the FileTargetArchiveMutexDispose branch from 2ecc3cd to 326fe54 Compare January 3, 2018 21:56
@codecov
Copy link

codecov bot commented Jan 3, 2018

Codecov Report

Merging #2485 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #2485   +/-   ##
======================================
  Coverage      82%     82%           
======================================
  Files         322     322           
  Lines       23628   23628           
  Branches     3057    3057           
======================================
  Hits        19392   19392           
  Misses       3483    3483           
  Partials      753     753

@snakefoot snakefoot force-pushed the FileTargetArchiveMutexDispose branch from 326fe54 to fea4312 Compare January 3, 2018 22:33
@snakefoot snakefoot force-pushed the FileTargetArchiveMutexDispose branch from fea4312 to 7cf8fd7 Compare January 3, 2018 22:44
@304NotModified 304NotModified added this to the 4.5 rc4 milestone Jan 3, 2018
@304NotModified 304NotModified added enhancement Improvement on existing feature file-target performance labels Jan 3, 2018
@304NotModified
Copy link
Member

👍 thanks!

@304NotModified 304NotModified merged commit a47033b into NLog:master Jan 3, 2018
@304NotModified 304NotModified added the file-archiving Issues with archiving with the file target label Aug 26, 2019
@snakefoot snakefoot modified the milestones: 4.5 rc4, 4.5 Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement on existing feature file-archiving Issues with archiving with the file target file-target performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants