FileTarget - Dynamic archive mode with more strict file-mask for cleanup

[snakefoot]

Avoid too aggressive cleanup when having multiple log-archives in the same folder.

Make the NLog 4.5 archive logic more userfriendly.

[codecov]

Codecov Report

Merging #2524 into master will decrease coverage by <1%.
The diff coverage is 85%.

@@           Coverage Diff           @@
##           master   #2524    +/-   ##
=======================================
- Coverage      82%     82%   -<1%     
=======================================
  Files         323     323            
  Lines       23375   23423    +48     
  Branches     2920    2931    +11     
=======================================
+ Hits        19060   19093    +33     
- Misses       3545    3559    +14     
- Partials      770     771     +1

[304NotModified]

Make the NLog 4.5 archive logic more userfriendly.

Could you elaborate on this?

more userfriendly

👍 👍

[snakefoot]

Could you elaborate on this?

Just look at the change of the unit-test, and you should see the problem this PR is trying to fix.

LogFile1 has this filename: log.txt
LogFile2 has this filename: log-other.txt

The automatic wildcard for LogFile1 will become log*.txt, which will also cleanup LogFile2 files.

[304NotModified]

is this a case we could unit test? (the first red part)

[304NotModified]

any idea if this could fix the unstable test " NLog.UnitTests.Targets.PlainFileTargetTests.SimpleFileDeleteTest(concurrentWrites: False, keepFileOpen: True, networkWrites: False, forceManaged: True, forceMutexConcurrentWrites: False, optimizeBufferReuse: True) [FAIL]"

See https://travis-ci.org/NLog/NLog/builds/329033070 (branch master...)

[snakefoot]

is this a case we could unit test? (the first red part)

It is just a safe-guard to ensure the double-string-iteration doesn't go bananas. You are welcome to think up a unit test.

[snakefoot]

any idea if this could fix the unstable test SimpleFileDeleteTest

Well my "fix" is to skip the keepfileopen-config for this test on MONO, as they seem very on unstable on Travis right now (Seems the FileWatcher is not doing its job very well, just like all config-auto-reload tests are skipped on Travis).