LoggingConfiguration - FindTargetByName should also find target + fix for logging on a target even after removed #2549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snakefoot
force-pushed
the
LoggingConfigurationFindTarget
branch
from
2c68a9e
to
bd32eff
Compare
Codecov Report
@@ Coverage Diff @@
## master #2549 +/- ##
=======================================
+ Coverage 82% 82% +<1%
=======================================
Files 323 323
Lines 23430 23501 +71
Branches 2936 2945 +9
=======================================
+ Hits 19097 19165 +68
- Misses 3554 3556 +2
- Partials 779 780 +1 |
snakefoot
force-pushed
the
LoggingConfigurationFindTarget
branch
9 times, most recently
from
40d2cf0
to
99ac80e
Compare
…gured with AddRule
snakefoot
force-pushed
the
LoggingConfigurationFindTarget
branch
from
99ac80e
to
cbe06ed
Compare
304NotModified
changed the title
|
thx! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When configured directly with
AddRule(Without usingAddTargetfirst)Also changed
RemoveTargetso it can safely remove an active target. Resolves #2227 (And replaces #2259)Discovered some tricky business with
AddTarget(string name, Target target), that allows one to register a target with a different alias (instead of the actual target-name). Trying to support removing target by alias, and still removing correctly from active LoggingRules (ReferenceEquals)