Make Set methods of MDC and MDLC return IDisposable

[MikeFH]

Attempt at implementing #2526

[codecov]

Codecov Report

Merging #2592 into master will decrease coverage by <1%.
The diff coverage is 79%.

@@           Coverage Diff           @@
##           master   #2592    +/-   ##
=======================================
- Coverage      81%     81%   -<1%     
=======================================
  Files         325     325            
  Lines       23918   23974    +56     
  Branches     3022    3026     +4     
=======================================
+ Hits        19408   19434    +26     
- Misses       3693    3728    +35     
+ Partials      817     812     -5

[304NotModified]

Cool! But unfortunately this is a breaking change.

So proposal to add a new method, Scope or something like that?

[MikeFH]

Got it.
I guess you can close this PR, I'll open a new one with another solution. I don't know when though, so if someone wants to look at it, it's cool.

[snakefoot]

You could also call the method Push or PushProperty (Leaving Set untouched, and making it a non-breaking change):

https://github.com/serilog/serilog/blob/3cd376c8c75ed49ab307c50cd80beaa06cbaecb7/src/Serilog/Context/LogContext.cs#L77

When doing the dispose, then it will Pop/Remove the property.

[304NotModified]

guess you can close this PR, I'll open a new one with another solution

Just push new commits on your branch, we can squash them later.

[304NotModified]

New methods. Name tba

[MikeFH]

I added a new method. It is called Push as suggested, but maybe it is a bit misleading since it might imply that the user works on a stack with this method (like in serilog) and that's not what we have here.

[304NotModified]

What do you think about SetScoped?

[MikeFH]

SetScoped it is.
I can still rename it if someone comes up with a better idea.

[MikeFH]

Build seems to be ok on my appveyor and travis accounts.

[304NotModified]

Build seems to be ok on my appveyor and travis accounts.

Tests are sometime a bit unstable :(

Will restart the CI

[304NotModified]

Looks great! merged!

Thanks!