Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileTarget - Failing to CreateArchiveMutex should not stop logging #2604

Merged
merged 2 commits into from
Mar 7, 2018

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Feb 28, 2018

Attempt to resolve #2602 (And also resolve #2607)

@304NotModified 304NotModified added file-target enhancement Improvement on existing feature labels Feb 28, 2018
@304NotModified 304NotModified added this to the 4.5 rc7 milestone Feb 28, 2018
@codecov
Copy link

codecov bot commented Feb 28, 2018

Codecov Report

Merging #2604 into master will decrease coverage by <1%.
The diff coverage is 22%.

@@           Coverage Diff           @@
##           master   #2604    +/-   ##
=======================================
- Coverage      81%     81%   -<1%     
=======================================
  Files         325     325            
  Lines       23938   23950    +12     
  Branches     3025    3028     +3     
=======================================
- Hits        19416   19402    -14     
- Misses       3704    3734    +30     
+ Partials      818     814     -4

@snakefoot snakefoot force-pushed the CreateArchiveMutexException branch 2 times, most recently from a93570d to b6bc333 Compare March 1, 2018 17:42
@snakefoot snakefoot force-pushed the CreateArchiveMutexException branch from d2d22ef to 6c074a4 Compare March 3, 2018 11:18
@304NotModified 304NotModified self-assigned this Mar 5, 2018
@snakefoot
Copy link
Contributor Author

@304NotModified Should not be forgotten :)

@304NotModified
Copy link
Member

Nope, I'm slowly checking all prs :)

@304NotModified 304NotModified merged commit 4380d8c into NLog:master Mar 7, 2018
@304NotModified
Copy link
Member

merged !

@snakefoot snakefoot mentioned this pull request Mar 15, 2018
@snakefoot snakefoot deleted the CreateArchiveMutexException branch April 4, 2020 17:56
@snakefoot snakefoot modified the milestones: 4.5 rc7, 4.5 Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement on existing feature file-target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants