MessageTemplates - Optimize ParseHole for positional templates #2639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before: |
snakefoot
force-pushed
the
MessageTemplateParseHoleOptimize
branch
from
506dbf2
to
462240b
Compare
Codecov Report
@@ Coverage Diff @@
## master #2639 +/- ##
=======================================
- Coverage 81% 81% -<1%
=======================================
Files 326 326
Lines 24032 24043 +11
Branches 3035 3037 +2
=======================================
Hits 19463 19463
- Misses 3744 3759 +15
+ Partials 825 821 -4 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize the Hole-Peek, so it it is less expensive than the entire string.Format()