Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw better error when target name is null #2763

Merged
merged 1 commit into from Jul 5, 2018
Merged

Throw better error when target name is null #2763

merged 1 commit into from Jul 5, 2018

Conversation

masters3d
Copy link
Contributor

If target.Name is null the rest of the code throws some weird error about 'key' being null which is unrelated.

@masters3d
add better error when target name is null
a18ee7a 
If target.Name is null the rest of the code throws some weird error about 'key' being null which is unrelated.
@304NotModified 304NotModified added the enhancement Improvement on existing feature label Jun 7, 2018
@304NotModified 304NotModified added this to the 4.5.7 milestone Jun 7, 2018
@304NotModified
Copy link
Member

Thanks!

@304NotModified 304NotModified changed the title add better error when target name is null Throw better error when target name is null Jun 7, 2018
@304NotModified 304NotModified merged commit 2219fd5 into NLog:master Jul 5, 2018
@masters3d masters3d deleted the patch-1 branch July 5, 2018 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@304NotModified 304NotModified 304NotModified approved these changes

Assignees
No one assigned
Labels
enhancement Improvement on existing feature nlog-configuration
Projects
None yet
Milestone
4.5.7
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@masters3d @304NotModified