Fix/callsite incorrect #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, it looks good |
ghost
merged commit 
ghost
pushed a commit
that referenced
this pull request
May 7, 2014
|
This has been reverted as this causes the Log_LoggerWrappedAndStackTraceEnabled_UserStackFrameIsCurrentMethod test to fail |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had the problem with callsite on certain x64 systems.. It reported NLog.LoggerImpl.Write instead of the actual callsite.. This fixes the problem for me:
Before:
2014-05-01 15:01:39.5402|33|Info|NLog.LoggerImpl.Write|User '' () logged in from xxx.xxx.xxx.xxx
After:
2014-05-01 15:03:02.7554|28|Info|Login.LoginUser|User '' () logged in from xxx.xxx.xxx.xxx