Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended ReplaceLayoutRendererWrapper and LayoutParser to support more advanced Regex replacements and more escape codes #357

Merged
5 commits merged into from
Jun 18, 2014

Conversation

DannyVarod
Copy link
Contributor

Added more escape code support for config file, enabling all C# escape codes (e.g. "\r", "\n", "\u1234" (see link[1] for full list)) in addtion to ":", "{" and "}".

Added option Regex replace parameter which enables replacement by group name from Regex pattern + additional tests. This enables more complex Regex-based replace scenarios.

[1]: Full list of C# escape codes: http://blogs.msdn.com/b/csharpfaq/archive/2004/03/12/what-character-escape-sequences-are-available.aspx

@ghost
Copy link

ghost commented Jun 9, 2014

Thanks for the pull request, I'll take a look at it

@ghost
Copy link

ghost commented Jun 15, 2014

Does this introduce any breaking changes?

@DannyVarod
Copy link
Contributor Author

@Xharze No - Didn't break any tests and in all the methods I touched I first read to understand the existing functionality and made sure it is preserved.

ghost pushed a commit that referenced this pull request Jun 18, 2014
Extended ReplaceLayoutRendererWrapper and LayoutParser to support more advanced Regex replacements and more escape codes
@ghost ghost merged commit cd61772 into NLog:master Jun 18, 2014
@ghost ghost added the enhancement label Jun 18, 2014
@ghost ghost added this to the 3.0.1 milestone Jun 18, 2014
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement on existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant