Fix for #365: Behaviour when logging null arguments #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parsing a [null] parameter in for example logger.Info("Testing null:
{0}", null); will result in not logging an event. A
System.NullReferenceException would be thrown causing the entire
logEvent NOT to be logged. This behavior is different from prior
versions. This fix will restore the previous behavior.
|
Looks good, could you create a test for this? |
Added unit test for fix NLog#365
|
@Xharze , test is added. |
|
As pointed out here: #355, it would be better to use: var logEvent = item as LogEventInfo; |
ghost
pushed a commit
that referenced
this pull request
Jun 18, 2014
Fix for #365: Behaviour when logging null arguments
ghost
merged commit 
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing a [null] parameter in for example logger.Info("Testing null: {0}", null); will result in not logging an event. A
System.NullReferenceException would be thrown causing the entire logEvent NOT to be logged. This behavior is different from prior versions. This fix will restore the previous behavior.