Use merging of event properties in async target wrapper to fix empty collection issue #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…collection issue The empty 'properties' collection (issue NLog#331) was fixed by copying the properties from the original object stored in the parameters. However, the async target wrapper 'Write' is overwritten such that the merge method is never called, causing the same issue when using <targets async="true"> configuration. The solution is to call the merge operation in the overridden 'Write' method.
ghost
pushed a commit
that referenced
this pull request
Jun 18, 2014
Use merging of event properties in async target wrapper to fix empty collection issue
ghost
merged commit 
ghost
added
the
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The empty 'properties' collection (issue #331) was fixed by copying the properties from the original object stored in the parameters. However, the async target wrapper 'Write' is overwritten such that the merge method is never called, causing the same issue when using configuration. The solution is to call the merge operation in the overridden 'Write' method.
I ran into this issue and was able to produce a solution that seems to work for us, but we have not used NLog extensively yet, so please take a look if this fix is any good.
Thanks!