Fix For Issue #7031 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue # 7031 Invalid configuration throws exception if the instance of new type is not created Possible reasons : Default constructor is not defined or not accessible Workaround : Guarding the method with try catch block. And creating default Instance of logger.
Updated code for Issue # 7031 Invalid configuration throws exception if the instance of new type is not created Possible reasons : Default constructor is not defined or not accessible Workaround : Guarding the method with try catch block. And creating default Instance of logger.
Fixed typo in code for creating default Logger Instance. And updated comment. Code changes was done for Issue # 7031
Fixed code for Issue so that if flag is set then the exception is thrown.
Created unit test function to test the fix for issue # 7031
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Issue Invalid configuration throws exception issue in Codeplex.
The GetCurrentClassLogger throws an exception , even if the flag ThrowExceptions is set to false.
As Reported in this codeplex : http://nlog.codeplex.com/workitem/7031
WorkAround : Guard CreateInstance method with try - catch block. And Handle the exception.