Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mailtarget allow empty 'To' and various code improvements #601

Merged
6 commits merged into from
Mar 19, 2015
Merged

Mailtarget allow empty 'To' and various code improvements #601

6 commits merged into from
Mar 19, 2015

Conversation

304NotModified
Copy link
Member

  • Allow empty 'To' (but at least To, CC or Bcc) should be set. Fixes MailTarget: remove mandatory To requirement  #599
  • Created a single method to create the message (was before scatterd)
  • Removed some code duplication on adding the addresses (parsing and
    rendering)
  • Always log the error in the log
  • added some comments

@304NotModified
Merge pull request #6 from NLog/master
9898513 
Sync back
@304NotModified
Allow empty To and code improvements
0601c07 
- Allow empty 'To' (but at least To, CC or Bcc) should be set
- Created a single method to create the message (was before scatterd)
- Removed some code duplication on adding the addresses (parsing and
rendering)
- added some comments
@304NotModified 304NotModified changed the title Mailtarget allow empty to Mailtarget allow empty 'To' and various code improvements Feb 21, 2015
@304NotModified 304NotModified added enhancement Improvement on existing feature feature labels Feb 21, 2015
@304NotModified
Copy link
Member Author

Ready for merge

@304NotModified
documentation and cleanup
a194749 
added docs and removed duplicate code
@304NotModified
added ctor for easier/cleaner exception handling
1bc2d93 
added ctor with string.format in `NLogRuntimeException` for
easier/cleaner exception handling
@304NotModified
Copy link
Member Author

Added some more code improvements and refactoring

ghost pushed a commit that referenced this pull request Mar 19, 2015
@kichristensen
Merge pull request #601 from 304NotModified/mailtarget-allow-empty-to
d9cfa65 
Mailtarget allow empty 'To' and various code improvements
@ghost ghost merged commit d9cfa65 into NLog:master Mar 19, 2015
@304NotModified 304NotModified added this to the 4.0 milestone Mar 27, 2015
@304NotModified 304NotModified deleted the mailtarget-allow-empty-to branch March 27, 2015 22:32
@304NotModified 304NotModified mentioned this pull request May 15, 2015
Closed
9 tasks
kevindaub pushed a commit to kevindaub/NLog-wiki that referenced this pull request Jul 31, 2015
Document optional To in mail target
0d4df40 
As introduced in NLog/NLog#601
@304NotModified 304NotModified added the documentation done all docs done (wiki, api docs, lists on nlog-project.org, xmldocs) label Jan 14, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation done all docs done (wiki, api docs, lists on nlog-project.org, xmldocs) enhancement Improvement on existing feature feature mail-target needs documentation on wiki
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@304NotModified @snakefoot