Bugfix: Broken xml stops logging #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Auto_reload_validxml_test succeeds - Auto_Reload_invalidxml_test fails
problem: XmlLoggingConfiguration.Initialize eats exception with invalid XML. ALso XmlLoggingConfiguration.Reload never returns null. So the null check is not enough - added InitializeSucceeded in XmlLoggingConfiguration - checks also InitializeSucceeded. If false, DON't apply the config. Result: invalidation XML wont stop logging, the old config will be used. Also, the auto reload won't turned to false (the default)
|
The changes are small, but a review would be wise because there is a new public property added. |
304NotModified
changed the title
I works locally
|
Looks good to me. Just wondering about all the linebreaks between the tests? Any reason for this? |
|
The line breaks is just bad coding style of me ;) - I like white space when programming. Most of the time I let Resharper fix this, but too bad the NLog code style if really different then my Resharper profile (I like I will fix this code styling thing with a commit. |
|
wtf. Removed newlines and now are the unit tests failing? |
|
Unit tests are fixed and PR is ready for merge after review. |
| @@ -62,6 +62,8 @@ public class XmlLoggingConfiguration : LoggingConfiguration | |||
|
|
|||
| private string originalFileName; | |||
|
|
|||
|
|
|||
|
@304NotModified Good work, please see my comments, otherwise it looks great |
|
Thanks. Unneeded newlines removed! |
ghost
pushed a commit
that referenced
this pull request
May 10, 2015
Bugfix: Broken xml stops logging
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #273
problem:
XmlLoggingConfiguration.Initializeeats exception with invalidXML. ALso
XmlLoggingConfiguration.Reloadnever returnsnull.So the
nullcheck is not enoughInitializeSucceeded(nullablebool) inXmlLoggingConfigurationInitializeSucceeded. Iffalse, DON't apply the config.Result: invalidating the XML won't stop logging, the old config will be used.
Also, the auto reload won't turned to
false(the default)The unit tests proves the solution and also the previous problem.