Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventLogTarget.Source layoutable & code improvements to EventLogTarget #705

Merged
merged 6 commits into from
May 16, 2015
Merged

EventLogTarget.Source layoutable & code improvements to EventLogTarget #705

merged 6 commits into from
May 16, 2015

Conversation

304NotModified
Copy link
Member

Note: on install/uninstall, the event source is only created / removed when the Source doesn't contain layout renderers. This is needed because we need a LogEventInfo when rendering the Layout, and there isn't a LogEventInfo when installing/uninstalling.

@304NotModified
Copy link
Member Author

Implemented this, because it's a breaking change (in behaviour) and the 4.0 release is the most suitable for that.

@304NotModified 304NotModified added the breaking change Breaking API change (different to semantic change) label May 15, 2015
304NotModified added a commit that referenced this pull request May 16, 2015
EventLogTarget.Source layoutable & code improvements to EventLogTarget
@304NotModified 304NotModified merged commit b6fb271 into NLog:master May 16, 2015
@304NotModified 304NotModified deleted the event-log-source3 branch September 12, 2015 18:20
@304NotModified 304NotModified added the documentation done all docs done (wiki, api docs, lists on nlog-project.org, xmldocs) label Jan 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Breaking API change (different to semantic change) documentation done all docs done (wiki, api docs, lists on nlog-project.org, xmldocs) enhancement Improvement on existing feature feature needs documentation on wiki should Have
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant