Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added SwallowAsync(Task) #776

Merged
merged 1 commit into from
Jul 17, 2015
Merged

Conversation

breyed
Copy link
Contributor

@breyed breyed commented Jun 23, 2015

implements #765

@304NotModified 304NotModified added this to the 4.1 milestone Jun 23, 2015
@304NotModified
Copy link
Member

Thanks, also for fixing the docs of another method. We will merge this with 4.1

@304NotModified 304NotModified added the enhancement Improvement on existing feature label Jun 28, 2015
304NotModified added a commit that referenced this pull request Jul 17, 2015
@304NotModified 304NotModified merged commit 2b5f8af into NLog:master Jul 17, 2015
@breyed
Copy link
Contributor Author

breyed commented Oct 5, 2015

I just noticed a typo in the documentation. I fixed it on the branch for the original pull request. Is there any need for another pull request.

@304NotModified
Copy link
Member

Yes, a new PR is needed, because it was already merged. Not sure if you can create a new PR from the current branch - otherwise creating a new one is 2 clicks (+ typing name)

@breyed
Copy link
Contributor Author

breyed commented Oct 6, 2015

Thanks. It turns out that the tweak I was considering had become irrelevant anyway due to other changes (I had been looking at the latest released code). Instead, several documentation enhancements were possible, which I put in PR #940.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement on existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants