Fix: exception is not correctly logged when calling without message #788
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added unit test for bug report: #787.
Without the message argument it's calling the generic version:
will call:
This method is interpreting the argument as
message
. (which is correct). I'm not sure how to fix this neat - theException
is (again) a special case.This is not a bug since NLog 4, but we said that since NLog 4 the exception parameter is always the first one.
N.B.: creating a special method for
Exception
, likeError(Exception ex)
won't solve it, as this works forExeption
but not for the sub classes ofException
- those will call the generic version.Dunno how to solve this neat. Only thing that come to mind: re-introduce the is Exception quirk which just was removed in NLog 4 (another method).
Also what should be the result of
Error(ex)
when the${message}
layout renderer is used?