added switch to JsonLayout to suppress the extra spaces #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extra spaces can now be omitted when using the JsonLayout. useful when every little byte matters.
|
Thanks It would be nice if we create one (append) method which add the optional spacing. Do you agree? |
|
That would work too. I was also thinking an extension method, that was the On Mon, Jul 13, 2015, 14:34 Julian Verdurmen notifications@github.com
|
|
I would like to merge this. But there is a conflict. Can you fix this? |
…bServiceTarget Added logrecievertest with ServiceHost
…ileParameters Improve docs `ICreateFileParameters`
|
We need also docs on the wiki. Can you add them (with an 4.1 note) |
extra spaces can now be omitted when using the JsonLayout. useful when every little byte matters.
Conflicts: src/NLog/Layouts/JsonLayout.cs
304NotModified
added a commit
that referenced
this pull request
Jul 23, 2015
added switch to JsonLayout to suppress the extra spaces
|
Thanks! It has been merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the extra spaces can now be suppressed for the JsonLayout. I found this modification to be useful when using a network target sending via UDP ... every little byte matters.
also added was a unit test and I tested the nlog file configuration (with the Nlog.test project) to ensure the configuration attribute was working correctly.