MDLC to support also .Net 4.0 (beside 4.5) #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed compiler #if directive to support .Net 4.0 and 4.5
UgurAldanmaz
changed the title
|
And the unit tests? |
|
I just changed the #if directive and compile it in 4.0. What kind of unit test can be written for this change? For references? If you guide me, I will write a unit test that appropriate with this changes. |
|
There should be already unit tests for this. Those need also enabled for. Net 4 It should be in the test project and the class name is almost the same. |
Changed unit tests that associated with MDLC.
|
You are right! Sorry for oversight. I changed and pushed it too. |
|
Yes, those where all of them (I used "find all references" in the .Net 4.5 solution, and I checked if there were more |
|
So good catch! 👍 |
304NotModified
added a commit
that referenced
this pull request
Aug 30, 2015
Changes at MDLC to support .Net 4.0 and .Net 4.5
304NotModified
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed compiler #if directive to support .Net 4.0 and 4.5