Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolete attribute doesn't specify the correct replacement #894

Merged
merged 1 commit into from
Sep 3, 2015

Conversation

vbfox
Copy link
Contributor

@vbfox vbfox commented Sep 3, 2015

Calls to Logger.Error(string, Exception) were displaying a warning of :

Use Error(LogLevel level, Exception exception, string message, params object[] args) method instead.

But the correct version to call doesn't contains the LogLevel

@304NotModified
Copy link
Member

Thanks, but you should change this in the Logger.tt.

Can you update the PR?

@vbfox
Copy link
Contributor Author

vbfox commented Sep 3, 2015

Yep, will do

Calls to `Logger.#LEVEL#(string, Exception)` were displaying a warning
of :

    Use #LEVEL#(LogLevel level, Exception exception, string message,
        params object[] args) method instead.

But the correct version to call doesn't contains the LogLevel
@304NotModified
Copy link
Member

Thanks

@304NotModified 304NotModified added the enhancement Improvement on existing feature label Sep 3, 2015
@304NotModified 304NotModified added this to the 4.2 milestone Sep 3, 2015
304NotModified added a commit that referenced this pull request Sep 3, 2015
Obsolete attribute doesn't specify the correct replacement
@304NotModified 304NotModified merged commit c94b8ab into NLog:master Sep 3, 2015
304NotModified added a commit that referenced this pull request Sep 9, 2015
@304NotModified 304NotModified modified the milestones: 4.2, 4.1.1 Sep 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement on existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants