Support object vals for mdlc #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| MappedDiagnosticsLogicalContext.Set(key, value); | ||
|
|
||
| Assert.Equal(value, MappedDiagnosticsLogicalContext.Get(key)); | ||
| } |
There was a problem hiding this comment.
this should be getObject? (see fail on appveyor (AV))
an unit test on MappedDiagnosticsLogicalContext.Get(key) (result should be "5"), would be also nice
There was a problem hiding this comment.
Sorry for this silly error :/ I fixed immediately and commit.
|
|
||
| MappedDiagnosticsLogicalContext.Set(key, value); | ||
|
|
||
| Assert.Equal(value.ToString(), MappedDiagnosticsLogicalContext.Get(key)); |
There was a problem hiding this comment.
The tostring isn't good here
There was a problem hiding this comment.
You are right. I just changed it.
304NotModified
added a commit
that referenced
this pull request
Sep 7, 2015
Support object vals for mdlc
|
Looks good! It has been merged! |
|
Closes #883 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I intend to create PR for #883
But there are unrelated commits that coming from my fork update process. I hope they will not cause problem.