Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #931. FileTarget: Log info concerning archiving to internal logger #952

Merged
merged 1 commit into from
Oct 21, 2015
Merged

Fixes #931. FileTarget: Log info concerning archiving to internal logger #952

merged 1 commit into from
Oct 21, 2015

Conversation

bhaeussermann
Copy link
Contributor

Also moved all of the archiving properties together.

@304NotModified
Copy link
Member

I think this will lead to conflicts when #930 has been merged.

I will do #930, and will check this one :) Thanks for the PR!

PS: please use the text "fixes ..." in your PR message.

@ie-zero
Copy link
Contributor

ie-zero commented Oct 14, 2015

I think you are right @304NotModified.

Actually, any change on FileTarget will potentially conflict with #930.

@ie-zero ie-zero mentioned this pull request Oct 21, 2015
Closed
@304NotModified 304NotModified added the enhancement Improvement on existing feature label Oct 21, 2015
@304NotModified 304NotModified added this to the 4.2 milestone Oct 21, 2015
@304NotModified
Copy link
Member

Thanks for this PR! It has been merged and will be released in the next version!

304NotModified added a commit that referenced this pull request Oct 21, 2015
@304NotModified
Merge pull request #952 from bhaeussermann/branch0
de23907 
Fixes #931. FileTarget: Log info concerning archiving to internal logger
@304NotModified 304NotModified merged commit de23907 into NLog:master Oct 21, 2015
@304NotModified 304NotModified added the file-archiving Issues with archiving with the file target label Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Improvement on existing feature file-archiving Issues with archiving with the file target
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bhaeussermann @304NotModified @ie-zero