Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getcurrentclasslogger documentation / error messages improvements #967

Merged
merged 7 commits into from
Oct 17, 2015
Merged

Getcurrentclasslogger documentation / error messages improvements #967

merged 7 commits into from
Oct 17, 2015

Conversation

304NotModified
Copy link
Member

Fixes partly #961

  • improved error message when passing a static class
  • improved error message when passing a class which doesn't inherit form Logger
  • Small performance improvement by precheck instead of try-catch
  • improved XML docs

@304NotModified 304NotModified added has unittests bug Bug report / Bug fix enhancement Improvement on existing feature labels Oct 17, 2015
@304NotModified 304NotModified changed the title Getcurrentclasslogger improvements [WIP] Getcurrentclasslogger documentation/ error messages improvements Oct 17, 2015
@304NotModified 304NotModified changed the title Getcurrentclasslogger documentation/ error messages improvements Getcurrentclasslogger documentation / error messages improvements Oct 17, 2015
@304NotModified 304NotModified added this to the 4.2 milestone Oct 17, 2015
304NotModified added a commit that referenced this pull request Oct 17, 2015
@304NotModified
Merge pull request #967 from NLog/getcurrentclasslogger-improvements
8ff7645 
Getcurrentclasslogger documentation / error messages improvements
@304NotModified 304NotModified merged commit 8ff7645 into master Oct 17, 2015
@304NotModified 304NotModified deleted the getcurrentclasslogger-improvements branch October 22, 2015 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Bug report / Bug fix enhancement Improvement on existing feature
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@304NotModified