Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse of inner layout was not always correct working. Escaping of colon and bracket was only with hack (
${literal:text=\:}
) possible. This is now fixed. It does still need an escape with\
. The work around is also still working.fixes #444 and #914
Working examples:
${when:when=1 == 1:Inner=Test\: Hello}
${when:when=1 == 1:Inner=Test\\Hello}
${when:when=1 == 1:Inner=Test\Hello}
${when:when=1 == 1:Inner=Test{Hello\}}
We need to escape
:
and}
in an inner layout because::
because it's a value separator.}
because it's the end of the layoutnote: no need to escape
\
.Fixes #914 confirmed with unit tests ("ComplexWhenWithHashTest" fails with master)