Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More tests inner parse + docs #981

Merged
merged 5 commits into from
Oct 21, 2015
Merged

Conversation

304NotModified
Copy link
Member

added more unit tests. Moved innerlayout tests from whenTests to simpleLayoutParserTests

Side note:

I tried allowing balanced brackets (e.g. {} doesn't need an escape), but this cannot be done without being fully backwardscompatible

@304NotModified 304NotModified changed the title More tests inner parse More tests inner parse + docs Oct 20, 2015
@304NotModified 304NotModified added the enhancement Improvement on existing feature label Oct 20, 2015
@304NotModified 304NotModified added this to the 4.2 milestone Oct 20, 2015
@codecov-io
Copy link

Current coverage is 70.65%

Merging #981 into master will decrease coverage by -0.03% as of b671b8a

@@            master    #981   diff @@
======================================
  Files          262     262       
  Stmts        14786   14792     +6
  Branches      1613    1614     +1
  Methods          0       0       
======================================
  Hit          10451   10451       
  Partial        401     401       
- Missed        3934    3940     +6

Review entire Coverage Diff as of b671b8a


Uncovered Suggestions

  1. +0.09% via ...oredConsoleTarget.cs#232...244
  2. +0.08% via ...c/NLog/LogFactory.cs#180...191
  3. +0.07% via ...anceCounterTarget.cs#308...318
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

304NotModified added a commit that referenced this pull request Oct 21, 2015
@304NotModified 304NotModified merged commit acbae19 into master Oct 21, 2015
@304NotModified 304NotModified deleted the more-tests-inner-parse branch October 22, 2015 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement on existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants