Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document FileTarget inner properties/methods #982

Merged
merged 1 commit into from
Oct 21, 2015
Merged

Document FileTarget inner properties/methods #982

merged 1 commit into from
Oct 21, 2015

Conversation

ie-zero
Copy link
Contributor

@ie-zero ie-zero commented Oct 21, 2015

No description provided.

@codecov-io
Copy link

Current coverage is 70.65%

Merging #982 into master will not affect coverage as of 6f52383

@@            master    #982   diff @@
======================================
  Files          262     262       
  Stmts        14792   14792       
  Branches      1613    1613       
  Methods          0       0       
======================================
  Hit          10452   10452       
  Partial        400     400       
  Missed        3940    3940

Review entire Coverage Diff as of 6f52383

Uncovered Suggestions

  1. +0.09% via ...oredConsoleTarget.cs#232...244
  2. +0.09% via ...c/NLog/LogFactory.cs#180...191
  3. +0.08% via ...anceCounterTarget.cs#308...318
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

304NotModified
304NotModified reviewed Oct 21, 2015
View reviewed changes
src/NLog/Targets/FileTarget.cs
@@ -68,14 +80,17 @@ public class FileTarget : TargetWithLayoutHeaderAndFooter, ICreateFileParameters
private IFileAppenderFactory appenderFactory;
private BaseFileAppender[] recentAppenders;
private Timer autoClosingTimer;
// The number of initialised files at any one time.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer xml docs here. Can you change that?

@304NotModified
Copy link
Member

Great! One small thing, see code comments.

@304NotModified 304NotModified added documentation enhancement Improvement on existing feature labels Oct 21, 2015
304NotModified added a commit that referenced this pull request Oct 21, 2015
@304NotModified
Merge pull request #982 from ie-zero/FileTarget-Document
4cece2f 
Document FileTarget inner properties/methods
@304NotModified 304NotModified merged commit 4cece2f into NLog:master Oct 21, 2015
@304NotModified
Copy link
Member

I will change the documentation to XML docs myself :)

@304NotModified 304NotModified added this to the 4.2 milestone Oct 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation enhancement Improvement on existing feature
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ie-zero @codecov-io @304NotModified