Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: file archiving DateAndSequence & FileArchivePeriod.Day won't work always (wrong switching day detected) #985

Merged
merged 3 commits into from
Oct 21, 2015
Merged

Fix: file archiving DateAndSequence & FileArchivePeriod.Day won't work always (wrong switching day detected) #985

merged 3 commits into from
Oct 21, 2015

Conversation

304NotModified
Copy link
Member

Fixes #964
Supersedes #965

Thanks @ie-zero for the help and suggestions!

TODO: Test at night (after 0:00)

@304NotModified 304NotModified changed the title Fix file target archive numbering date and sequence won't work at night2 Fix: file target archive won't work always (when switching days) Oct 21, 2015
@304NotModified 304NotModified changed the title Fix: file target archive won't work always (when switching days) Fix: file archiving DateAndSequence & FileArchivePeriod.Day won't work always (wrong switching day detected) Oct 21, 2015
@codecov-io
Copy link

Current coverage is 70.65%

Merging #985 into master will not affect coverage as of 6830bf6

@@            master    #985   diff @@
======================================
  Files          262     262       
  Stmts        14792   14792       
  Branches      1613    1613       
  Methods          0       0       
======================================
  Hit          10452   10452       
  Partial        400     400       
  Missed        3940    3940

Review entire Coverage Diff as of 6830bf6

Uncovered Suggestions

  1. +0.09% via ...oredConsoleTarget.cs#232...244
  2. +0.09% via ...c/NLog/LogFactory.cs#180...191
  3. +0.08% via ...anceCounterTarget.cs#308...318
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

304NotModified added a commit that referenced this pull request Oct 21, 2015
@304NotModified
Merge pull request #985 from NLog/fix-FileTarget_ArchiveNumbering_Dat…
a296ff4 
…eAndSequence-won't-work-at-night2

Fix: file archiving DateAndSequence & FileArchivePeriod.Day won't work always (wrong switching day detected)
@304NotModified 304NotModified merged commit a296ff4 into master Oct 21, 2015
@304NotModified 304NotModified added the bug Bug report / Bug fix label Oct 21, 2015
@304NotModified 304NotModified added this to the 4.2 milestone Oct 21, 2015
@304NotModified 304NotModified deleted the fix-FileTarget_ArchiveNumbering_DateAndSequence-won't-work-at-night2 branch October 22, 2015 19:04
@304NotModified 304NotModified added the file-archiving Issues with archiving with the file target label Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Bug report / Bug fix file-archiving Issues with archiving with the file target
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@304NotModified @codecov-io