Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added more unit tests for max archive with dates in files. #986

Merged
merged 3 commits into from
Oct 21, 2015
Merged

Added more unit tests for max archive with dates in files. #986

merged 3 commits into from
Oct 21, 2015

Conversation

304NotModified
Copy link
Member

For prove fix of #390

also improved some code and comments

@304NotModified 304NotModified added the enhancement Improvement on existing feature label Oct 21, 2015
@codecov-io
Copy link

Current coverage is 70.66%

Merging #986 into master will increase coverage by +0.01% as of 3d0d228

@@            master    #986   diff @@
======================================
  Files          262     262       
  Stmts        14792   14793     +1
  Branches      1613    1613       
  Methods          0       0       
======================================
+ Hit          10452   10453     +1
  Partial        400     400       
  Missed        3940    3940

Review entire Coverage Diff as of 3d0d228

Uncovered Suggestions

  1. +0.08% via ...oredConsoleTarget.cs#232...244
  2. +0.08% via ...c/NLog/LogFactory.cs#180...191
  3. +0.07% via ...anceCounterTarget.cs#308...318
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@codecov-io
Copy link

Current coverage is 70.66%

Merging #986 into master will increase coverage by +0.01% as of 43af236

@@            master    #986   diff @@
======================================
  Files          262     262       
  Stmts        14792   14793     +1
  Branches      1613    1613       
  Methods          0       0       
======================================
+ Hit          10452   10453     +1
  Partial        400     400       
  Missed        3940    3940

Review entire Coverage Diff as of 43af236

Uncovered Suggestions

  1. +0.08% via ...oredConsoleTarget.cs#232...244
  2. +0.08% via ...c/NLog/LogFactory.cs#180...191
  3. +0.07% via ...anceCounterTarget.cs#308...318
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@304NotModified 304NotModified added this to the 4.2 milestone Oct 21, 2015
@304NotModified 304NotModified mentioned this pull request Oct 21, 2015
Closed
304NotModified added a commit that referenced this pull request Oct 21, 2015
@304NotModified
Merge pull request #986 from NLog/archive-max-files-test
b0eec80 
Added more unit tests for max archive with dates in files.
@304NotModified 304NotModified merged commit b0eec80 into master Oct 21, 2015
@304NotModified 304NotModified added the file-archiving Issues with archiving with the file target label Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Improvement on existing feature file-archiving Issues with archiving with the file target
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@304NotModified @codecov-io