Introduce FileAppenderCache class #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 24, 2015 11:20
Extract the functionality related to file appenders (BaseFileAppenders) used within the FileTarget class into a new class named FileAppenderCache. This change should improve the code readability and encourage further refactorings. It also re-enforces the Single Responsibility Principle.
Merge 'NLog/master' into FileTarget-FileAppenderCache and resolve merging conflicts between the two branches.
Current coverage is
|
Separate the constructor of the "empty" FileAppenderCache instance for clarity and document the class.
304NotModified
added a commit
that referenced
this pull request
Nov 5, 2015
Introduce FileAppenderCache class
|
Thanks again! also for the unit tests 👍 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract the functionality related to file appenders (
BaseFileAppenders) used within theFileTargetclass into a new class namedFileAppenderCache.This change should improve the code readability and encourage further refactorings. It also re-enforces the Single Responsibility Principle.
The "new" code does not change the implementation of the functionality related to file appenders. It simply separates it out of the
FileTargetclass.There are no breaking changes in my knowledge.