Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File target: auto add .zip to compressed archive when archiveName isn't specified. #995

Merged
merged 1 commit into from
Oct 24, 2015

Conversation

bhaeussermann
Copy link
Contributor

Fixes #932

@codecov-io
Copy link

Current coverage is 70.69%

Merging #995 into master will increase coverage by +0.03% as of f7dd4ad

@@            master    #995   diff @@
======================================
  Files          262     262       
  Stmts        14793   14793       
  Branches      1613    1614     +1
  Methods          0       0       
======================================
+ Hit          10453   10458     +5
+ Partial        400     399     -1
+ Missed        3940    3936     -4

Review entire Coverage Diff as of f7dd4ad


Uncovered Suggestions

  1. +0.09% via ...oredConsoleTarget.cs#232...244
  2. +0.08% via ...c/NLog/LogFactory.cs#180...191
  3. +0.07% via ...anceCounterTarget.cs#308...318
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@304NotModified 304NotModified added this to the 4.2 milestone Oct 24, 2015
@304NotModified
Copy link
Member

Thanks! I will include this on also in 4.2 (release today)

PS: please add the Fixes #932 in the body and not in the title. It doens't work in the title...

@304NotModified 304NotModified changed the title Fixes #932: ArchiveFileCompression: auto add .zip to filename ArchiveFileCompression: auto add .zip to filename Oct 24, 2015
@304NotModified 304NotModified changed the title ArchiveFileCompression: auto add .zip to filename ArchiveFileCompression: auto add .zip to compressed filename when archiveName isn't specified Oct 24, 2015
304NotModified added a commit that referenced this pull request Oct 24, 2015
ArchiveFileCompression: auto add `.zip` to compressed filename when archiveName isn't specified
@304NotModified 304NotModified merged commit af5c38c into NLog:master Oct 24, 2015
@304NotModified 304NotModified changed the title ArchiveFileCompression: auto add .zip to compressed filename when archiveName isn't specified File target: auto add .zip to compressed name of archive when archiveName isn't specified Oct 24, 2015
@304NotModified 304NotModified changed the title File target: auto add .zip to compressed name of archive when archiveName isn't specified File target: auto add .zip to compressed archive when archiveName isn't specified. Oct 24, 2015
@304NotModified 304NotModified added the file-archiving Issues with archiving with the file target label Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
file-archiving Issues with archiving with the file target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants