Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit Tests added to LogFactory class #999

Merged
merged 3 commits into from
Oct 26, 2015
Merged

Unit Tests added to LogFactory class #999

merged 3 commits into from
Oct 26, 2015

Conversation

ie-zero
Copy link
Contributor

@ie-zero ie-zero commented Oct 25, 2015

Unit tests added to cover SuspendLogging(), ResumeLogging(), EnableLogging() and DisableLogging() methods in LogFactory class.

Iraklis E added 2 commits October 25, 2015 05:15
Unit Tests added to LogFactory class
61c6352 
Unit tests added to cover SuspendLogging(), ResumeLogging(),
EnableLogging() and DisableLogging() methods in LogFactory class.
Fix using statements in LogFactory tests
4f752a7
@codecov-io
Copy link

Current coverage is 71.60%

Merging #999 into master will increase coverage by +0.06% as of f2475a4

@@            master    #999   diff @@
======================================
  Files          262     262       
  Stmts        14793   14793       
  Branches      1611    1611       
  Methods          0       0       
======================================
+ Hit          10584   10592     +8
+ Partial        417     415     -2
+ Missed        3792    3786     -6

Review entire Coverage Diff as of f2475a4

Uncovered Suggestions

  1. +0.09% via ...c/NLog/LogFactory.cs#180...191
  2. +0.08% via ...anceCounterTarget.cs#308...318
  3. +0.08% via ...anceCounterTarget.cs#294...304
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@304NotModified
Copy link
Member

:)

@304NotModified 304NotModified added the enhancement Improvement on existing feature label Oct 26, 2015
@304NotModified 304NotModified added this to the 4.3 milestone Oct 26, 2015
304NotModified added a commit that referenced this pull request Oct 26, 2015
@304NotModified
Merge pull request #999 from ie-zero/LogFactory-UnitTests
cf289f6 
Unit Tests added to LogFactory class
@304NotModified 304NotModified merged commit cf289f6 into NLog:master Oct 26, 2015
@ie-zero ie-zero deleted the LogFactory-UnitTests branch October 26, 2015 20:52
@304NotModified 304NotModified modified the milestones: 4.3, 4.2.1 Nov 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Improvement on existing feature
Projects
None yet
Milestone
4.2.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ie-zero @codecov-io @304NotModified