Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagger crashes when dealing with non-valid UTF-8 encoding #35

Closed
CloneMMDDCVII opened this issue Jun 26, 2022 · 3 comments
Closed

Tagger crashes when dealing with non-valid UTF-8 encoding #35

CloneMMDDCVII opened this issue Jun 26, 2022 · 3 comments
Labels
bug Something isn't working in-beta This issue is fixed in a beta version

Comments

@CloneMMDDCVII
Copy link

Tags containing non UTF-8 make Tagger crash when attempting to write them to a file name.
I've got a few hundred songs to tag from an IPod, and any accented characters makes Tagger crash when attempting to write filename using tags.

(org.nickvision.tagger:2): Pango-WARNING **: 11:36:29.707: Invalid UTF-8 string passed to pango_layout_set_text()
terminate called after throwing an instance of 'std::filesystem::__cxx11::filesystem_error'
  what():  filesystem error: cannot rename: Invalid or incomplete multibyte or wide character [/media/pierre/Powerdrive/Alex/IPod8G/EQDF.mp3] [/media/pierre/Powerdrive/Alex/IPod8G/J'ai Demand� La Lune- Indochine.mp3]
]

Expected behaviour:
Tagger either prompts user for source encoding and re-encodes to UTF-8 (could offer to convert metadata to UTF-8 as well while at it) or escape non UTF-8 encoding so Tagger doesn't crash

(thanks so much for the app by the way, it's really a godsend)

@nlogozzo nlogozzo added the bug Something isn't working label Jul 6, 2022
@nlogozzo
Copy link
Member

nlogozzo commented Jul 6, 2022

I plan on rewriting Tagger with QT (using libadwaita styled controls similar to Fedora Media Writer). Will fix in that release, just may take a little bit.

@nlogozzo nlogozzo added the in-beta This issue is fixed in a beta version label Jul 31, 2022
@nlogozzo
Copy link
Member

nlogozzo commented Aug 3, 2022

8f3cc9b

@nlogozzo
Copy link
Member

nlogozzo commented Aug 5, 2022

@nlogozzo nlogozzo closed this as completed Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in-beta This issue is fixed in a beta version
Projects
None yet
Development

No branches or pull requests

2 participants