Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double values are serialized with commas as decimal points #228

Closed
jplatte opened this issue Mar 31, 2016 · 5 comments
Closed

double values are serialized with commas as decimal points #228

jplatte opened this issue Mar 31, 2016 · 5 comments

Comments

@jplatte
Copy link

jplatte commented Mar 31, 2016

Might be related to #51. As a workaround I can start my application with LC_ALL=C, but this is obviously something that should be fixed in the library. I'm using git master.

@nlohmann
Copy link
Owner

Hi @jplatte, which locale are you using when the bug occurs?

It's time to approach this issue...

@jplatte
Copy link
Author

jplatte commented Mar 31, 2016

Not sure exactly how locale identifiers in std::locale correspond to the various locale variables on my system, but it should be something like de_DE.UTF-8, de_DE.utf8 or just de.

@nlohmann
Copy link
Owner

nlohmann commented Apr 5, 2016

I created a branch with a fix: https://github.com/nlohmann/json/tree/issue228

@jplatte Could you please check if this works for you?

@jplatte
Copy link
Author

jplatte commented Apr 6, 2016

It does work. Thanks!

@nlohmann nlohmann added this to the Release 2.0.0 milestone Apr 7, 2016
@nlohmann nlohmann self-assigned this Apr 7, 2016
@nlohmann
Copy link
Owner

nlohmann commented Apr 7, 2016

@jplatte FYI: I now merged the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants