Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

releasing single header file in compressed format #316

Closed
agauniyal opened this issue Sep 23, 2016 · 10 comments
Closed

releasing single header file in compressed format #316

agauniyal opened this issue Sep 23, 2016 · 10 comments
Labels
kind: enhancement/improvement solution: wontfix the issue will not be fixed (either it is impossible or deemed out of scope)

Comments

@agauniyal
Copy link

This is more of a feature request since a few c++ build systems enforce downloading of zip/tar.gz archives instead of direct files, would you mind releasing an archive for just json.hpp file in future releases. Currently, I've to clone whole repo which doesn't seems nice way to do things on a limited bandwidth network 😄

@agauniyal
Copy link
Author

Btw I've added your package to wrapdb - https://wrapdb.mesonbuild.com/json which is based on meson build system.

@kainjow
Copy link

kainjow commented Oct 5, 2016

You could try cloning with a depth of 1, which won't grab the entire repository history:

git clone --depth 1 https://github.com/nlohmann/json.git

@agauniyal
Copy link
Author

Unfortunately I don't have control over it, I can only specify the archive url. Another reason is that some packages might do git checkout v2.3 or such which should require that history I guess.

@nlohmann
Copy link
Owner

nlohmann commented Oct 6, 2016

About which build system are we talking? Adding another file to a release is some (manual) work on my side - I would like to understand whether this is worth the effort.

@nlohmann nlohmann added the state: please discuss please discuss the issue or vote for your favorite option label Oct 6, 2016
@agauniyal
Copy link
Author

@nlohmann I've linked it above but here it is - https://github.com/mesonbuild/meson/

@agauniyal
Copy link
Author

You can also automate github releases as per as your requirements 😄 . And you're already attaching json.hpp, I'm just asking for a tar.gz version for it, if I wasn't clear. That should be 1 more command at most.

@nlohmann
Copy link
Owner

nlohmann commented Oct 6, 2016

This seems to be a limitation of the meson build system not to be able to download a .hpp file, but only archives.

@agauniyal
Copy link
Author

Yes I've also raised a issue here - mesonbuild/meson#744, but the developers seem to be quite busy atm and I thought I could ask for some support here. If it's too complicated, I won't mind downloading whole sources as I'm doing currently, but it would be a lot helpful on limited bandwidth network for some of use.

@nlohmann
Copy link
Owner

nlohmann commented Oct 6, 2016

I understand, but if the issue affects more than one project, it makes a lot of sense to fix this in the build system rather than each individual project. Though downloading whole archives is quite ugly, it is also the same as Homebrew is doing (see https://github.com/nlohmann/homebrew-json). I would like to close this issue, because I think mesonbuild/meson#744 should fix this.

@agauniyal
Copy link
Author

I understand 👍

@nlohmann nlohmann added solution: wontfix the issue will not be fixed (either it is impossible or deemed out of scope) and removed state: please discuss please discuss the issue or vote for your favorite option labels Oct 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement/improvement solution: wontfix the issue will not be fixed (either it is impossible or deemed out of scope)
Projects
None yet
Development

No branches or pull requests

3 participants