Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ordered_json doesn't accept keys of types other than string_t (e.g., string_view) #3558

Closed
2 tasks done
falbrechtskirchinger opened this issue Jun 27, 2022 · 0 comments · Fixed by #3564
Closed
2 tasks done

ordered_json doesn't accept keys of types other than string_t (e.g., string_view) #3558

falbrechtskirchinger opened this issue Jun 27, 2022 · 0 comments · Fixed by #3564
Assignees
@nlohmann
Labels
kind: bug release item: 🔨 further change solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Milestone
Release 3.11.0

Comments

@falbrechtskirchinger
Copy link
Contributor

falbrechtskirchinger commented Jun 27, 2022 •
edited
Loading

Description

When adding support for string_view, we overlooked that ordered_map used by ordered_json would also need an update to properly support types other than object_t::key_type/string_t.

Reproduction steps

See discussion #3556.

Expected vs. actual results

See discussion #3556.

Minimal code example

No response

Error messages

No response

Compiler and operating system

any

Library version

develop

Validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nlohmann nlohmann

Labels
kind: bug release item: 🔨 further change solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Projects
None yet
Milestone
Release 3.11.0
2 participants
@nlohmann @falbrechtskirchinger