Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone is long due to large history #4370

Closed
1 of 2 tasks
Nir-Az opened this issue May 9, 2024 · 4 comments
Closed
1 of 2 tasks

Clone is long due to large history #4370

Nir-Az opened this issue May 9, 2024 · 4 comments
Labels
solution: wontfix the issue will not be fixed (either it is impossible or deemed out of scope)

Comments

@Nir-Az
Copy link

Nir-Az commented May 9, 2024

Description

json repo history is very big.
CMake ExternalProject_Add does not support shallow clone of a specific commit, that makes us work hard to minimize the clone part that happens on build step.

I suggest to use git tools to reduce history size
W/O history repo is ~ 7 [MB]
with history it's ~ 185 [MB]

Reproduction steps

image

Expected vs. actual results

Here how it looks w/o history
image

Minimal code example

No response

Error messages

Clone step occasionally fail on timeout

Compiler and operating system

Windows / Linux

Library version

3.11.3 but also latest

Validation

@nlohmann
Copy link
Owner

nlohmann commented May 9, 2024

Use the .xz archives instead.

@Nir-Az
Copy link
Author

Nir-Az commented May 9, 2024

That an option yes.
Managed WA it this way: https://github.com/IntelRealSense/librealsense/pull/12914/files

But releases are not git source controlled and may be broken in the future, if you rename it in the future my link will be broken right?

reducing the history is a better long run approach IMO.

Thoughts?

@nlohmann
Copy link
Owner

I had this discussions a while ago. I will not change this repository's history. If you want a quick download, take the .xz archive. If you want to check out the repository, deal with its size. Sorry.

@nlohmann nlohmann added the solution: wontfix the issue will not be fixed (either it is impossible or deemed out of scope) label May 10, 2024
@Nir-Az
Copy link
Author

Nir-Az commented May 10, 2024

NP, just raised an enhancement.
Thanks for the hard work on this great repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solution: wontfix the issue will not be fixed (either it is impossible or deemed out of scope)
Projects
None yet
Development

No branches or pull requests

2 participants