Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actix 3 release bump #32

Closed
clux opened this issue Sep 13, 2020 · 3 comments
Closed

actix 3 release bump #32

clux opened this issue Sep 13, 2020 · 3 comments

Comments

@clux
Copy link

clux commented Sep 13, 2020

Thanks for this crate! This is probably a simple one :-)

actix 3 was just released, and it probably requires a bump of actix herein, as I'm seeing this when upgrading:

error[E0271]: type mismatch resolving `<actix_web_prom::PrometheusMetrics as actix_web::dev::Transform<<impl actix_service::ServiceFactory as actix_service::ServiceFactory>::Service>>::Request == actix_web::dev::ServiceRequest`
   --> version.rs:100:14
    |
100 |             .wrap(prometheus.clone())
    |              ^^^^ expected struct `actix_web::service::ServiceRequest`, found struct `actix_web::dev::ServiceRequest`
    |
    = note: perhaps two different versions of crate `actix_web` are being used?
@nlopes
Copy link
Owner

nlopes commented Sep 16, 2020

Which version of the crate are you using? 0.5.0 should have actix-web at version 3 and actix-service at 1.0.6.

If you're not on 0.5.0, please upgrade to 0.5.0.

@clux
Copy link
Author

clux commented Sep 16, 2020

Ah, 0.5.0 wasn't out when I tested. That version works. Thank you!

@clux clux closed this as completed Sep 16, 2020
@nlopes
Copy link
Owner

nlopes commented Sep 16, 2020

Thanks for raising, truly appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants