Skip to content
This repository has been archived by the owner on Jul 20, 2020. It is now read-only.

Support "approval-category-id"-related arguments for comment-added hook #2

Closed
deepbrook opened this issue Sep 7, 2018 · 3 comments
Closed

Support "approval-category-id"-related arguments for comment-added hook #2

deepbrook opened this issue Sep 7, 2018 · 3 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@deepbrook
Copy link
Owner

These are currently not supported by the parser we build.

Implement them.
@deepbrook deepbrook added enhancement New feature or request good first issue Good for newcomers bug Something isn't working and removed good first issue Good for newcomers labels Sep 7, 2018
@deepbrook
Copy link
Owner Author

Since this hinges entirely on the values of the IDs, this is stuck until I find out their values.

I've asked for pointers here

@deepbrook
Copy link
Owner Author

According to stackoverflow, approval-category-ids are equivalent to their labels.

@deepbrook
Copy link
Owner Author

Added in version 1.0.0

deepbrook pushed a commit that referenced this issue Sep 14, 2018
Issue-#2 Support approval categories for comment-added hook.
e8e814f 
By default, the Code-Review and Verified labels are supported.
Custom approval categories are supported as well; these can
be added using gerrit_hooks.hook.add_custom_approval_category().
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@deepbrook