Zipfile raises error when "assert self.fp is None" in Python3.6

[AndreasMadsen]

I only get this error on occasion and only in a production-like environment after running some code for several hours. The only thing related to nltk is that I use the MosesTokenizer.

I've tried quite a things even setting self.fp = None manually after self.close() is called, nothing worked. In the end I had to just make OpenOnDemandZipFile an alias for zipfile.ZipFile.

I'm using python 3.6 which may be the cause of the error.

  File "/zhome/ff/2/77654/stdpy3/lib/python3.6/site-packages/nltk/corpus/reader/wordlist.py", line 78, in words
    return [line for line in line_tokenize(self.raw(fileids))
  File "/zhome/ff/2/77654/stdpy3/lib/python3.6/site-packages/nltk/corpus/reader/wordlist.py", line 28, in raw
    return concat([self.open(f).read() for f in fileids])
  File "/zhome/ff/2/77654/stdpy3/lib/python3.6/site-packages/nltk/corpus/reader/wordlist.py", line 28, in <listcomp>
    return concat([self.open(f).read() for f in fileids])
  File "/zhome/ff/2/77654/stdpy3/lib/python3.6/site-packages/nltk/corpus/reader/api.py", line 211, in open
    stream = self._root.join(file).open(encoding)
  File "/zhome/ff/2/77654/stdpy3/lib/python3.6/site-packages/nltk/data.py", line 511, in open
    data = self._zipfile.read(self._entry)
  File "/zhome/ff/2/77654/stdpy3/lib/python3.6/site-packages/nltk/data.py", line 995, in read
    assert self.fp is None

[alvations]

Yes, definitely Python 3.6 is the problem because ZipFile works a little differently on 3.5 -> 3.6.

Related issue: #1659

In fact, this is one of the major roadblock to support Python3.6, any module that uses zipfile from nltk.data would result in similar error at the assertion line.

@AndreasMadsen want to try a poke at #1659 ? ;P

[AndreasMadsen]

@alvations I don't need it enough to allocate the hours to fix it, sorry.

[alvations]

Similar to #1696.

We're preparing for #1659, anyone still having this issue on Python 2.7, 3.5 or > 3.6.1 ?