Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For FreqDist plotting, no longer show plot by default #3085

Merged
merged 1 commit into from Feb 20, 2023

Conversation

tomaarsen
Copy link
Member

Resolves #2788

Hello!

Pull Request overview

  • For FreqDist and ConditionalFreqDist, only return the ax rather than also showing the plot by default.

Details

See #2788 for details. Note that the third case mentioned in that issue has already been solved in 8c75972.

  • Tom Aarsen

@tomaarsen tomaarsen added the plot label Dec 13, 2022
@stevenbird stevenbird self-assigned this Dec 22, 2022
@stevenbird stevenbird merged commit cbe715a into nltk:develop Feb 20, 2023
@stevenbird
Copy link
Member

I wish we'd done it this way from the start!

@tomaarsen tomaarsen deleted the deprecate/no_show_default branch February 20, 2023 11:53
@tomaarsen
Copy link
Member Author

Well, the second best time to plant a tree... 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only return ax object by default in plot methods, instead of plotting by default
2 participants