Function validate_options() in http.lua currently rejects cookies with unrecognized attributes. Per RFC 6265, Section 5.2 such attributes should be ignored:
Process the attribute-name and attribute-value according to the requirements in the following subsections. (Notice that attributes with unrecognized attribute-names are ignored.)
The current behavior has real-world impact. As an example, Digi devices set cookies with attribute version:
Set-Cookie: SID=c98fefa3ad659caa20b89582419bb14f; Max-Age=1200; Version=1
The following trivial patch remediates the issue:
@@ -302,7 +302,8 @@
elseif not (cookie_key == 'httponly' or cookie_key == 'secure') then
stdnse.debug1("http: Unknown field in cookie table: %s", cookie_key)
- bad = true
+ -- Ignore unrecognized attributes (per RFC 6265, Section 5.2)
+ -- bad = true
Please let me know if you have any questions or concerns. Otherwise I will commit the patch in a few weeks.
Sounds fine to me. The raw header is still available in the rawheader field, so no info is lost.
Actually the changed code preserves unknown attributes in the cookie object. There is no reason to inspect rawheader.
What the changed code does is to allow cookies acquired from previous response to be passed as-is (in the options parameter) to the next request. (Before this change the next request would error out because of the unrecognized cookie attribute.)