Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media namespace not available on AtomFeed #34

Closed
valeriomazzeo opened this issue Aug 12, 2017 · 7 comments
Closed

Media namespace not available on AtomFeed #34

valeriomazzeo opened this issue Aug 12, 2017 · 7 comments

Comments

@valeriomazzeo
Copy link

Currently, media attributes are parsed only as part of an RSSFeedItem.

I may be wrong, but perhaps it should be possible for something like this:

<media:thumbnail width="40" height="40" url="https://secure.gravatar.com/avatar/1234"/>

to be contained inside an AtomFeedEntry.

@nmdias
Copy link
Owner

nmdias commented Aug 12, 2017

Well, of the top of my head, I don't see any reason for Atom not to be able to extend the Media namespace. I'll add support as soon as I get some time on my hands.

@valeriomazzeo
Copy link
Author

thanks @nmdias, do you have any idea when will you be able to do it?

@nmdias
Copy link
Owner

nmdias commented Aug 30, 2017

Honestly, I was waiting for Xcode 9 GM. I don’t even have Xcode 8 anymore.

I’ll try to do it this weekend 👍

@valeriomazzeo
Copy link
Author

@nmdias that would be great, please let me know if you need any help

@nmdias
Copy link
Owner

nmdias commented Sep 2, 2017

Hi @valeriomazzeo,

Whenever you get that chance, give the master branch a go and check if it's working well for you.

Thanks

@valeriomazzeo
Copy link
Author

valeriomazzeo commented Sep 2, 2017

@nmdias that's great, just tried and it works nicely.

I would really appreciate if you could release a new version on cocoapods, as I have a podspec that depends on FeedKit, unfortunately I can't make the dependency point to the master branch.

@nmdias
Copy link
Owner

nmdias commented Sep 3, 2017

@valeriomazzeo -> 6.1.2 is out in the wild.

@nmdias nmdias closed this as completed Sep 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants