Typo in SS-timevaryparm.tpl L221

[zandjyo]

https://github.com/nmfs-stock-synthesis/stock-synthesis/blob/70c765caf3e4468b8131e15287eaef01c620238f/SS_timevaryparm.tpl#L221

The environmental link option '4', logistic link, is not working properly.
I think there is a typo in line 221:

parm_timevary(tvary,y1)=2.00000/(1.00000 + mfexp(-timevary_parm(timevary_parm_cnt+1)(env_data(yz,timevary_setup(7))-timevary_parm(timevary_parm_cnt))));

should read

parm_timevary(tvary,y1)=2.00000/(1.00000 + mfexp(-timevary_parm(timevary_parm_cnt+1)(env_data(y1,timevary_setup(7))-timevary_parm(timevary_parm_cnt))));

[Rick-Methot-NOAA]

change has been made; also for line 352.
Both occurrences are long lines of code, so I expect that when yz was updated to y1, only the first occurrence on the line got changed.

[k-doering-NOAA]

@zandjyo Here is the ss executable to test: https://github.com/nmfs-stock-synthesis/stock-synthesis/actions/runs/647154096 . Just scroll down to the "artifacts" section and click on ss_win_exe . Could you see if that fixes the issue for you?

Note this exe has some newer changes since 3.30.16 and is experimental, so you may run into some other differences that are unrelated to the bug fix. Feel free to reach out if there is anything happening that doesn't make sense!

[zandjyo]

Appears to now be working as intended. Thanks! Steve

…

On Fri, Mar 12, 2021 at 11:28 AM Kathryn Doering ***@***.***> wrote: @zandjyo <https://github.com/zandjyo> Here is the ss executable to test: https://github.com/nmfs-stock-synthesis/stock-synthesis/actions/runs/647154096 . Just scroll down to the "artifacts" section and click on ss_win_exe . Could you see if that fixes the issue for you? Note this exe has some newer changes since 3.30.16 and is experimental, so you may run into some other differences that are unrelated to the bug fix. Feel free to reach out if there is anything happening that doesn't make sense! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#148 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJFGJPYZN4AOB3TWXF227LTDJMKXANCNFSM4ZCVBPOQ> .

-- Steven J. Barbeaux Ph.D. Research Fisheries Biologist Alaska Fisheries Science Center, National Marine Fisheries Service National Oceanic and Atmospheric Administration 7600 Sand Point Way NE, Seattle, WA 98115 USA Tel: (206) 526-4211

[k-doering-NOAA]

Great -Thanks for reporting!