Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete database structure #13

Closed
jmatike opened this issue Feb 25, 2022 · 3 comments
Closed

Incomplete database structure #13

jmatike opened this issue Feb 25, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@jmatike
Copy link

jmatike commented Feb 25, 2022

When I see your JSON resource files, you have many informations that are not present in the database structure. For example in the countries.json you have missing data like numeric_code, tld, languages, emoji. Same for timezone table which lack of information, also states

Is there any update you are working on ?

@nnjeim nnjeim added help wanted Extra attention is needed enhancement New feature or request and removed help wanted Extra attention is needed labels Feb 25, 2022
@nnjeim
Copy link
Owner

nnjeim commented Feb 25, 2022

@jmatike True, more country information is available in the json source files. I have tried to limit to the minimum needed for the general business information. Yes i would consider in the upcoming version giving the ability to include more fields.
Thank you for your input.

@jmatike
Copy link
Author

jmatike commented Feb 25, 2022

Thanks. 👍🏾

@nnjeim
Copy link
Owner

nnjeim commented Mar 7, 2022

@jmatike please have a look at release 1.1.4, thanks for your constructive input.

@nnjeim nnjeim closed this as completed Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants