Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proto3 Not Supported #68

Closed
tmazeika opened this issue Jul 9, 2015 · 11 comments
Closed

Proto3 Not Supported #68

tmazeika opened this issue Jul 9, 2015 · 11 comments

Comments

@tmazeika
Copy link

tmazeika commented Jul 9, 2015

It seems that the proto3 syntax is unsupported, as errors occur when I remove required and optional keywords, as required by proto3. While it is still in alpha, basic support for it may at least alleviate the littering of errors all over the file.

@wenerme
Copy link

wenerme commented Aug 7, 2015

Syntax with service not support.

syntax = "proto3";

option java_package = "play";

package play;


// The request message containing the user's name.
message HelloRequest {
    string name = 1;
}

// The response message containing the greetings
message HelloReply {
    string message = 1;
}

// The greeter service definition.
service Greeter {
    // Sends a greeting
    rpc SayHello (HelloRequest) returns (HelloReply) {}
    rpc SayHelloToThem(HelloRequest) returns (stream HelloReply) {}
    rpc SayHelloToAll(stream HelloRequest) returns (stream HelloReply) {}
}

@IceMan81
Copy link
Contributor

It would be nice to have support for proto3. Thanks for the work you have put in to create this plugin.

@ramtej
Copy link

ramtej commented Aug 13, 2015

+1 for proto3 support

@akaspin
Copy link

akaspin commented Aug 21, 2015

+1

1 similar comment
@flzyup
Copy link

flzyup commented Sep 20, 2015

+1

@mwitkow
Copy link

mwitkow commented Sep 24, 2015

Pretty please :)

@depend
Copy link

depend commented Sep 28, 2015

+1

@kshchepanovskyi
Copy link

+1

image

@leebird
Copy link

leebird commented Oct 9, 2015

+1. Thanks!

@tcripps tcripps closed this as completed in e25a177 Nov 7, 2015
@IceMan81
Copy link
Contributor

IceMan81 commented Nov 9, 2015

@tcripps Thanks a lot for this fix!

@ramtej
Copy link

ramtej commented Nov 9, 2015

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants